[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

Sat Feb 9 05:08:31 PST 2019

rengolin reopened this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Right, this is a completely different patch and it seems that the original proposal hadn't been tested thoroughly.

It did feel as the initial patch was far too simple for what it enabled, but I thought this was due to implementations in the intrinsic selection that I didn't follow for the past year or two.

By looking over this new patch, it feels as though most changes are mechanical, but I'm afraid I don't have enough familiarity with the code base any more to be sure without further testing.

Given that this review is "approved" and "closed" and then reverted, and that the implementation is now totally different than the original approved patch, I'll reopen this one and request revision again.

Also, the Clang part (D53928 <https://reviews.llvm.org/D53928>) seems to have changed significantly after approved, so that, too, would need revisiting. I have updated that review to look at it again.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927