[PATCH] D57979: [dsymutil] Don't clone empty CUs

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/CompileUnit.cpp:60
+  if (NewUnit) {
+    NextUnitOffset += 11 /* Header size */;
     NextUnitOffset += NewUnit->getUnitDie().getSize();
----------------
@friss Do you remember why that comment is there? Isn't a header without a DW_TAG_compile_unit invalid DWARF?


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:2274
+    if (CurrentUnit->getOutputUnitDIE()) {
+      Linker.Streamer->emitCompileUnitHeader(*CurrentUnit);
+      Linker.Streamer->emitDIE(*CurrentUnit->getOutputUnitDIE());
----------------
This change looks reasonable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57979/new/

https://reviews.llvm.org/D57979