[PATCH] D57533: lit: support long paths on Windows

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 15:28:28 PST 2019


efriedma added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:614
+                    # to use the NT style path to get access to long file paths
+                    # which cannot be removed otherwise.
+                    from ctypes.wintypes import BOOL, HWND, LPCWSTR, POINTER, UINT, WORD
----------------
Please add a comment noting which version of python, exactly, are known to have a broken shutil.rmtree, so we can potentially remove this hack in the future.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list