[PATCH] D57952: llvm-lib: Implement /list flag

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp:99
 
+static void fatalOpenError(std::error_code EC, Twine File) {
+  if (!EC)
----------------
Could you make this take an `llvm::Error` and change the caller with the `error_code` to use `errorCodeToError`? We're (slowly) trying to eradicate `std::error_code` and `errorToErrorCode` from the codebase.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/Options.td:14
+
+// Can't be called "lsit" since that's a keyword.
+def lst    : F<"list">, HelpText<"List contents of .lib file on stdout">;
----------------
typo "list"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57952/new/

https://reviews.llvm.org/D57952