[PATCH] D57974: [lld-link] better error message when failing to open archive members

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 13:52:27 PST 2019


inglorion added inline comments.


================
Comment at: lld/COFF/Driver.cpp:228-230
+  auto ReportBufferError = [](Error &&E,
+                              StringRef SymName,
+                              StringRef ParentName,
----------------
ruiu wrote:
> I wouldn't pass SymName and ParentName and just capture them using `[&]`.
  [ =] is better for StringRefs, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57974/new/

https://reviews.llvm.org/D57974





More information about the llvm-commits mailing list