[PATCH] D57963: Fix Die() after pthread_exit call on macOS
Yuri Per via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 8 11:54:03 PST 2019
yuri marked 2 inline comments as done.
yuri added inline comments.
================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:1055
+ {
+ SCOPED_INTERCEPTOR_RAW(pthread_exit, retval);
+ }
----------------
vitalybuka wrote:
> Why do we need SCOPED_INTERCEPTOR like this if we do nothing inside of its scope?
>
> BTW. I am trying to remove it completely as Dmitry suggested r353552
I copied this construction from other place in the same file. I guess it is intended for logging. There are several interceptors (for example, longjmp) that has the same structure. Moreover, In the next patch CHECK using 'thr' will be added into this scope.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57963/new/
https://reviews.llvm.org/D57963
More information about the llvm-commits
mailing list