[PATCH] D57957: [NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value.
Sergey Dmitriev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 8 11:54:04 PST 2019
sdmitriev marked 2 inline comments as done.
sdmitriev added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:184
struct OutlineRegionInfo {
- OutlineRegionInfo(SmallVector<BasicBlock *, 8> Region,
+ OutlineRegionInfo(const SmallVector<BasicBlock *, 8> &Region,
BasicBlock *EntryBlock, BasicBlock *ExitBlock,
----------------
vsk wrote:
> Consider ArrayRef<BasicBlock *>, to avoid leaking an implementation detail ("8")?
Done.
================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:538
DominateVector, DominateVector.front(), ExitBlock, ReturnBlock);
RegInfo.Region = DominateVector;
OutliningInfo->ORI.push_back(RegInfo);
----------------
vsk wrote:
> This copy seems dead?
Right, this assignment looks dead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57957/new/
https://reviews.llvm.org/D57957
More information about the llvm-commits
mailing list