[PATCH] D54749: Saturating float to int casts: Basics [1/n]

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:961-963
+  llvm_unreachable("fp_to_xint soften float op not implemented yet");
+  return SDValue();
+}
----------------
I'm pretty sure this will warn. There's no point in doing this anyway since you'll get the appropriate error if you just leave this out


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2358
+                                                   SDValue &Hi) {
+  llvm_unreachable("fp_to_xint_sat expand int res not implemented yet");
+}
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749