[PATCH] D57533: lit: support long paths on Windows

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 10:09:59 PST 2019


zturner added a comment.

In D57533#1390388 <https://reviews.llvm.org/D57533#1390388>, @thakis wrote:

> I think getting the rest of unxutils is also a huge roadblock. So we could either add llvm-grep and all the other unix utils we rely on, or we could have a script checked in somewhere that downloads a known-good version of unxutils for use on Windows. That would fix this issue here and would make running llvm tests on Windows much easier in general.


Instead of adding `llvm-grep`, `llvm-rm`, `llvm-sed`, etc, I would rather just implement `grep`, `rm`, and `sed` directly in Python as builtins in the internal lit shell, as that will help us eventually migrate all users exclusively to the LIT shell, and we have more control over fixing bugs and ensuring consistency across platforms.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list