[PATCH] D57957: [NFC] Pass blocks vector to the OutlineRegionInfo constructor by reference.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:184
   struct OutlineRegionInfo {
-    OutlineRegionInfo(SmallVector<BasicBlock *, 8> Region,
+    OutlineRegionInfo(const SmallVector<BasicBlock *, 8> &Region,
                       BasicBlock *EntryBlock, BasicBlock *ExitBlock,
----------------
Consider ArrayRef<BasicBlock *>, to avoid leaking an implementation detail ("8")?


================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:538
           DominateVector, DominateVector.front(), ExitBlock, ReturnBlock);
       RegInfo.Region = DominateVector;
       OutliningInfo->ORI.push_back(RegInfo);
----------------
This copy seems dead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57957/new/

https://reviews.llvm.org/D57957