[PATCH] D57960: [Support] Fix TempFile::discard to not leave behind temporary files

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 09:56:50 PST 2019


ruiu added a comment.

This class should do a minimum number of attempt to remove a file, instead of trying to remove a file at various points to increase the chance to successfully removing the file. Why don't you close the file before removing the file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57960/new/

https://reviews.llvm.org/D57960





More information about the llvm-commits mailing list