[PATCH] D49714: AMDGPU/GlobalISel: Implement select for G_EXTRACT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.
Herald added subscribers: Petar.Avramovic, jvesely.
Herald added a project: LLVM.


================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:169
+  MachineRegisterInfo &MRI = MF->getRegInfo();
+  unsigned SubReg = TRI.getSubRegFromChannel(I.getOperand(2).getImm() / 32);
+  DebugLoc DL = I.getDebugLoc();
----------------
This should assert that it's a multiple of 32


================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:176-179
+    if (!MO.isReg())
+      continue;
+    if (TargetRegisterInfo::isPhysicalRegister(MO.getReg()))
+      continue;
----------------
Neither of these are legal situations


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49714/new/

https://reviews.llvm.org/D49714