[PATCH] D57511: [DebugInfo] Stop changing labels for register-described parameter DBG_VALUEs

[David Stenberg via Phabricator via llvm-commits]

dstenb marked an inline comment as done.
dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:240
           const DIExpression *Fragment = I->first->getDebugExpression();
           if (std::all_of(Ranges.begin(), I,
                           [&](DbgValueHistoryMap::InstrRange Pred) {
----------------
aprantl wrote:
> Does this become more readable by changing it to
> 
> ```
>    if (!std::all_of(...))
>     break;
>   if (!IsDescribedByRef(...))
> ```
> ?
Yes; thanks! I inverted it to an any_of() also.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57511/new/

https://reviews.llvm.org/D57511