[PATCH] D57945: Small refactoring of FileError. NFC

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 05:45:04 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the comment fix.



================
Comment at: include/llvm/Support/Error.h:1218-1219
 
+/// Concatenate a source file path and/or name with an Error. Also build
+/// Error object from std::error_code.
+inline Error createFileError(const Twine &F, std::error_code EC) {
----------------
I'd rephrase this slightly to say "Concatenate a source file path and/or name with a std::error_code to form an Error object", and then delete the second sentence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57945/new/

https://reviews.llvm.org/D57945





More information about the llvm-commits mailing list