[PATCH] D57929: [InstrProf] Implement static profdata registration

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingValue.c:34
     lprofValueProfNodes[INSTR_PROF_VNODE_POOL_SIZE] COMPILER_RT_SECTION(
-       COMPILER_RT_SEG INSTR_PROF_VNODES_SECT_NAME_STR);
+       COMPILER_RT_SEG INSTR_PROF_VNODES_SECT_NAME);
 #endif
----------------
What is this change for?


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:682
                                                InstrProfIncrementInst *Inc,
-                                               const Triple &TT) {
+                                               Triple &TT) {
   if (!needsComdatForCounter(F, M))
----------------
Why is const removed?


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:758
+  // the counters an external linkage like linkonce_odr.
+  if (TT.isOSBinFormatCOFF() && Cmdt &&
+      Cmdt != Fn->getComdat())
----------------
can this code be moved closer to where COFF linkage handling above (i.e. resetting to internal)?


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:901
+  // On COFF, it's important to reduce the alignment down to 1 to prevent the
+  // linker from insertin padding before the start of the names section or
+  // between names entries.
----------------
insertin --> inserting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57929/new/

https://reviews.llvm.org/D57929