[PATCH] D57941: test-release.sh: Add option to use ninja

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 8 01:47:18 PST 2019


rovka created this revision.
rovka added reviewers: hans, tstellar.
Herald added a project: LLVM.

Allow the use of ninja instead of make. This is useful on some
platforms where we'd like to be able to limit the number of link jobs
without slowing down the other steps of the release.

This patch adds a -use-ninja command line option, which sets the
generator to Ninja both for LLVM and the test-suite. It also deals with
some differences between make and ninja:

- DESTDIR handling - ninja doesn't like this to be listed after the target, but both make and ninja can handle it before the command
- Verbose mode - ninja uses -v, make uses VERBOSE=1
- Keep going mode - make has a -k mode, which builds as much as possible even when failures are encountered; for ninja we need to set a hard limit (we use 100 since most people won't look at 100 failures anyway)

I haven't been able to test with gmake.


Repository:
  rL LLVM

https://reviews.llvm.org/D57941

Files:
  utils/release/test-release.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57941.185928.patch
Type: text/x-patch
Size: 3827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190208/935dc642/attachment.bin>


More information about the llvm-commits mailing list