[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Overall looks good.

> Do you mean that of those three options, the last one specified should take precedence?

Yes.



================
Comment at: ELF/Config.h:191
   bool ZGlobal;
+  GnuStackKind ZGnustack;
   bool ZHazardplt;
----------------
Members are (roughly) sorted alphabetically, so move this below the last boolean member.


================
Comment at: ELF/Driver.cpp:352
+      return GnuStackKind::Exec;
+    else if (StringRef("noexecstack") == Arg->getValue())
+      return GnuStackKind::NoExec;
----------------
nit: no `else` after `return`.


================
Comment at: ELF/Driver.cpp:369
          S == "nodelete" || S == "nodlopen" || S == "noexecstack" ||
+         S == "nognustack" ||
          S == "nokeep-text-section-prefix" || S == "norelro" || S == "notext" ||
----------------
If you have clang-format, please run it on this file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56554/new/

https://reviews.llvm.org/D56554