[PATCH] D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 16:27:51 PST 2019


aprantl added inline comments.


================
Comment at: tools/llvm-dwarfdump/Statistics.cpp:283
     VarWithLoc += Stats.TotalVarWithLoc + Constants;
-    VarTotal += TotalVars + Constants;
+    VarTotal += TotalVars;
     VarUnique += Stats.VarsInFunction.size();
----------------
I think we still need the `+ Constants` here or VarTotal can be smaller than VarWithLoc which would be unintuitive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57849/new/

https://reviews.llvm.org/D57849





More information about the llvm-commits mailing list