[PATCH] D57449: GlobalISel: Add alignment to LegalityQuery MMOs
Daniel Sanders via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 7 16:07:48 PST 2019
dsanders added a comment.
In D57449#1389860 <https://reviews.llvm.org/D57449#1389860>, @arsenm wrote:
> I'm not sure why the MMO alignment is uint64_t in the first place. The maximum supported alignment is 1 << 29 (which I guess when converted to bits is 1 too many for uint32)
Hmm, 1 << 29 is in range for both uint32_t and int32_t so it's presumably just an overly large return type. Fair enough, I think it would be good to fix the oversized return value so that people don't have to silence these warnings but that's not for this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57449/new/
https://reviews.llvm.org/D57449
More information about the llvm-commits
mailing list