[PATCH] D57929: [InstrProf] Implement static profdata registration

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformOther.c:64
+   */
+  ptrdiff_t DataBytes = (const char *)DataLast - (const char *)DataFirst;
+  ptrdiff_t CounterBytes =
----------------
davidxl wrote:
> register function won't be called with static registration. Why is this change needed?
This change isn't needed anymore. I suppose Solaris is the only supported platform that uses this now, and perhaps the risk that the linker lays out the profile data discontiguously is negligible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57929/new/

https://reviews.llvm.org/D57929