[PATCH] D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format

[Dan Gohman via llvm-commits]

This is now fixed in r353476.

Dan

On Thu, Feb 7, 2019 at 3:22 PM Vitaly Buka via Phabricator <
reviews at reviews.llvm.org> wrote:

> vitalybuka added a comment.
>
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/10518
>
>   FAIL: LLVM :: tools/llvm-readobj/symbols.test (29567 of 29761)
>   ******************** TEST 'LLVM :: tools/llvm-readobj/symbols.test'
> FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> --symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.coff-i386
>   |
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/FileCheck
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/symbols.test
> -check-prefix COFF
>   : 'RUN: at line 3';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> --symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.elf-i386
>   |
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/FileCheck
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/symbols.test
> -check-prefix ELF
>   : 'RUN: at line 5';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> --symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.wasm
>   |
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/FileCheck
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/symbols.test
> -check-prefix WASM
>   : 'RUN: at line 9';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> --symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.elf-i386
> >
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.symbols
>   : 'RUN: at line 10';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> --syms
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.elf-i386
> >
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.syms
>   : 'RUN: at line 11';   cmp
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.syms
>   : 'RUN: at line 12';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readobj
> -t
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.elf-i386
> >
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.t
>   : 'RUN: at line 13';   cmp
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.t
>   : 'RUN: at line 14';
>  /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llvm-readelf
> -s -elf-output-style LLVM
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/Inputs/trivial.obj.elf-i386
> >
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.lowers
>   : 'RUN: at line 15';   cmp
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.symbols
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/test/tools/llvm-readobj/Output/symbols.test.tmp.lowers
>   --
>   Exit Code: 1
>
>   Command Output (stderr):
>   --
>
> /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/test/tools/llvm-readobj/symbols.test:107:12:
> error: WASM-NEXT: is not on the line after the previous match
>   WASM-NEXT: Module: env
>              ^
>   <stdin>:31:8: note: 'next' match was here
>    ImportModule: env
>          ^
>   <stdin>:29:3: note: previous match ended here
>    ]
>     ^
>   <stdin>:30:1: note: non-matching line after previous match is here
>    ImportName: puts
>   ^
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57632/new/
>
> https://reviews.llvm.org/D57632
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190207/ce0ae78a/attachment-0001.html>