[PATCH] D57909: [WebAssembly] Don't generate invalid modules when function signatures mismatch

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 15:37:57 PST 2019


sbc100 added a comment.

In D57909#1389792 <https://reviews.llvm.org/D57909#1389792>, @ruiu wrote:

> Ah, thanks for the explanation. I think that makes sense to me.
>
> If you create a module with a invalid function type, what would happen at runtime? Does it fail to load?


Yes, the browser would fail to validate the module.

Now it will validate, and even run, as long as you don't hit that invalid call sites.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57909/new/

https://reviews.llvm.org/D57909





More information about the llvm-commits mailing list