[PATCH] D57264: Bump minimum toolchain version

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 14:20:21 PST 2019


hubert.reinterpretcast added a comment.

In D57264#1389686 <https://reviews.llvm.org/D57264#1389686>, @jfb wrote:

> Regarding libstdc++: the check is currently conservatively correct, but not thorough enough, because older revisions of GCC still get bug fix release which pass the date check. Past GCC 7 we can use `_GLIBCXX_RELEASE`, but before this @tstellar points out how LLDB does it <https://github.com/llvm/llvm-project/blob/master/lldb/cmake/modules/LLDBConfig.cmake#L423>. I don't know if we have to fix this issue: we simply fail to warn a small subset of libstdc++ users.


My local RHEL 7.5 machines all pass the date check by accident. The date shows as `20150623`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57264/new/

https://reviews.llvm.org/D57264





More information about the llvm-commits mailing list