[PATCH] D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/tools/llvm-dwarfdump/X86/stats-inlining-multi-cu.ll:9
 ; CHECK-SAME: "unique source variables":4
-; CHECK-SAME: "source variables":6
+; CHECK-SAME: "source variables":8
 ; CHECK-SAME: "variables with location":6
----------------
aprantl wrote:
> cmtice wrote:
> > aprantl wrote:
> > > Where do the extra two variables come from?
> > There are two inlined instances, each of which has 3 variables (parameter T,  i from the first lexical block, i from the second lexical block); function a has a local variable 'a'; function b has a local variable 'b'.  Total = 8.
> Is this counting the template parameter T as a variable? That seems wrong to me. I think we should only count entities that could have a `DW_AT_location` in their DW_TAG.
Pedantically, a DW_TAG_template_value_parameter can have a DW_AT_location, for instance.

(but yeah, I agree - a count of variables probably shouldn't include template (type, value or otherwise) parameters)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57849/new/

https://reviews.llvm.org/D57849