[PATCH] D57348: [CodeGen][X86] Don't scalarize vector saturating add/sub

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 13:30:46 PST 2019


nikic marked an inline comment as done.
nikic added a comment.
Herald added a project: LLVM.

The relevant part of PR40442 has been resolved now.



================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:5325
-         "Expected operands to be integers. Vector of int arguments should "
-         "already be unrolled.");
   assert(LHS.getValueType() == RHS.getValueType() &&
----------------
RKSimon wrote:
> You can keep this but just change to isInteger()?
I removed those because I thought these asserts are now redundant with the specification in TargetSelectionDAG.td, or is that not enforced?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57348/new/

https://reviews.llvm.org/D57348





More information about the llvm-commits mailing list