[PATCH] D57215: [CodeExtractor] Update function's assumption cache after extracting blocks from it

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 12:38:34 PST 2019


hfinkel added inline comments.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:1422
+  if (AC)
+    AC->clear();
+
----------------
sdmitriev wrote:
> hfinkel wrote:
> > Can we clear here less than everything?
> I have updated changes to remove extracted llvm.assume calls from the old function's assumption cache instead of clearing it.
But then they'll be missing and it won't rescan? Why don't we add an interface like movedToNewFunction(CallInst *CI), and let the cache actually update itself properly?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57215/new/

https://reviews.llvm.org/D57215





More information about the llvm-commits mailing list