[PATCH] D57919: [CodeExtractor] Restore outputs after creating exit stubs

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks! This mostly looks good, and I believe it resolves llvm.org/PR40455.



================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:1141
+      InsertPt = std::next(OutI->getIterator());
+
+    assert(OAI != newFunction->arg_end() &&
----------------
Could you assert that the insertion point is in 'newFunction'?


================
Comment at: unittests/Transforms/Utils/CodeExtractorTest.cpp:203
+
+    define i32 @foo(i32 %x, i32 %y) personality i8* null {
+    entry:
----------------
Are the 'entry' and 'cond.true' blocks needed to reproduce the issue?


================
Comment at: unittests/Transforms/Utils/CodeExtractorTest.cpp:231
+
+  DominatorTree DT(*Func);
+  CodeExtractor CE(Block, &DT);
----------------
Is DT needed?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57919/new/

https://reviews.llvm.org/D57919