[PATCH] D57656: GlobalISel: Fix artifact combiner constant legality checks for vectors

[Matt Arsenault via Phabricator via llvm-commits]

arsenm closed this revision.
arsenm added a comment.

r353449



================
Comment at: test/CodeGen/AMDGPU/GlobalISel/artifact-combiner-sext.mir:16
+    ; CHECK: [[UV:%[0-9]+]]:_(s32), [[UV1:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[COPY1]](<2 x s32>)
+    ; CHECK: [[SHL:%[0-9]+]]:_(s32) = G_SHL [[UV]], [[C]](s32)
+    ; CHECK: [[SHL1:%[0-9]+]]:_(s32) = G_SHL [[UV1]], [[C]](s32)
----------------
aditya_nandakumar wrote:
> Is this correct ? We're shifting a 32 bit source by 32 into 32 bit destination.
Thanks, I have another patch where I've been auditing all the getSizeInBits which should be getScalarSizeInBits


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57656/new/

https://reviews.llvm.org/D57656