[PATCH] D57904: [llvm-objdump] Allow short options to be grouped

Thu Feb 7 10:49:09 PST 2019

ormris added inline comments.

================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:110
 static cl::list<std::string>
 DisassembleFunctions("df",
                      cl::CommaSeparated,
----------------
rupprecht wrote:
> This conflicts with -d and -f when grouped args are allowed
Is renaming this option possible? It doesn't seem to fit with the naming scheme...

================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:200
 cl::alias static FilterSectionsj("j", cl::desc("Alias for --section"),
-                                 cl::NotHidden,
+                                 cl::NotHidden, cl::Grouping,
                                  cl::aliasopt(llvm::FilterSections));
----------------
rupprecht wrote:
> I'm very much interested in this being supported (i.e. I've seen `objdump -sj.foo` as mentioned in the bug), but according to http://llvm.org/docs/CommandLine.html#grouping, grouped args can't take values.
True. I'll remove this for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57904/new/

https://reviews.llvm.org/D57904