[PATCH] D57841: [x86] narrow 256-bit horizontal ops via demanded elements

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 10:40:34 PST 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one (optional) minor.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:32981
+      EVT VT128 = EVT::getVectorVT(*TLO.DAG.getContext(), VT.getScalarType(),
+                                   VT.getVectorNumElements() / 2);
+      SDValue NarrowHop = TLO.DAG.getNode(Opc, DL, VT128, Ext0, Ext1);
----------------
You should be able to just use Ext0.getValueType()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57841/new/

https://reviews.llvm.org/D57841





More information about the llvm-commits mailing list