[PATCH] D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I would recommend bumping the version number, too, since the results from earlier versions won't be comparable, right?



================
Comment at: test/tools/llvm-dwarfdump/X86/stats-inlining-multi-cu.ll:7
 ; CHECK:      "source functions":4,
-; CHECK-SAME: "inlined functions":5,
+; CHECK-SAME: "inlined functions":2,
 ; CHECK-SAME: "unique source variables":4
----------------
Seems right.


================
Comment at: test/tools/llvm-dwarfdump/X86/stats-inlining-multi-cu.ll:9
 ; CHECK-SAME: "unique source variables":4
-; CHECK-SAME: "source variables":6
+; CHECK-SAME: "source variables":8
 ; CHECK-SAME: "variables with location":6
----------------
Where do the extra two variables come from?


================
Comment at: tools/llvm-dwarfdump/Statistics.cpp:139
            GlobalStats.ScopeBytesFromFirstDefinition);
-  } else {
+  } else if (Die.getTag() == dwarf::DW_TAG_member) {
     FnStats.ConstantMembers++;
----------------
That looks definitely correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57849/new/

https://reviews.llvm.org/D57849