[PATCH] D57463: Add a module pass for order file instrumentation

[Manman Ren via Phabricator via llvm-commits]

manmanren marked an inline comment as done.
manmanren added inline comments.


================
Comment at: lib/Transforms/Instrumentation/InstrOrderFile.cpp:147
+    // We need to wrap around the index to fit it inside the buffer.
+    Value *WrappedIdx = updateB.CreateAnd(
+        IdxVal, ConstantInt::get(Int32Ty, INSTR_ORDER_FILE_BUFFER_MASK));
----------------
davidxl wrote:
> Why not having a runtime interface to flush the buffer here?
Can you give an example of a runtime interface? Are you referring to helpers in another file maybe InstrProfiling.cpp?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57463/new/

https://reviews.llvm.org/D57463