[PATCH] D57844: Handle CalledProcessError without a Python stack
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 7 10:18:55 PST 2019
rnk marked an inline comment as done.
rnk added inline comments.
================
Comment at: zorg/buildbot/builders/annotated/annotated_builder.py:44
+ # print the return code and fail the step.
+ if exn and isinstance(exn, subprojects.CalledProcessError):
+ cmd = ""
----------------
inglorion wrote:
> Did you mean "subprocess" instead of "subprojects"?
Editing code without tests is scary. :) Even to test this manually, I have to find a way to set up a failing build.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57844/new/
https://reviews.llvm.org/D57844
More information about the llvm-commits
mailing list