[PATCH] D57533: lit: support long paths on Windows

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 10:13:25 PST 2019


rnk added a comment.

In D57533#1388253 <https://reviews.llvm.org/D57533#1388253>, @thakis wrote:

> Why isn't "if you want to put your build at c:\very_long_path, use a rm that can handle that" good enough as a stopgap measure?


Because that's a landmine we leave behind for every person who wants to set up a Windows bot to run lit tests, no matter how much documentation we write about it. Hand rolling rm ourselves also has maintenance costs, but I believe in the long run the costs will be lower than telling everyone to use a special version of rm. Of course, that is just my estimate of the relative cost of the two proposals, and I'm prepared to be wrong.

I think we've already covered this, and it seems we're not in agreement yet. Should we reach out to other Windows bot maintainers and get more opinions?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list