[PATCH] D57881: [DTU] Refine the document of mutation APIs [NFC] (PR40528)

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

In D57881#1388903 <https://reviews.llvm.org/D57881#1388903>, @kuhar wrote:

> Nice, thanks for working on this!


Agreed, thank you!

> I'd like to first go forward with this patch, after minor corrections, and then mark insertEdge/deleteEdge as deprecated, migrate their uses to applyUpdates, and later remove it entirely. Then we can note put a note in GenericDomTree saying that for the llvm trees,  DTU should be used instead.

+1
The `insertEdge()` and `deleteEdge()` direct calls require so much manual fix-up at the call-sites I'd really prefer to see them go away. It also provides a cleaner interface to `DTU`  as a whole, opening up opportunities to alter the underlying class without changing call semantics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57881/new/

https://reviews.llvm.org/D57881