[PATCH] D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 05:47:30 PST 2019


CarlosAlbertoEnciso marked an inline comment as done.
CarlosAlbertoEnciso added inline comments.


================
Comment at: test/CodeGen/X86/bbi-23595.ll:12
+;
+; The issue was introduced at https://reviews.llvm.org/rL345250.
+
----------------
aprantl wrote:
> I would put all this meta-info in the commit message and instead focus on describing what is being tested here. Something like: We're expecting the dbg.label to disappear because ...
I have updated the patch following your comments and I will use the standard short message in the commit.

I will include in the bugzilla, the following text:

```
Note: This patch is a complement to pr38762.

For the given test case, the verifier complains with the error message:

LLVM ERROR: Broken function found, compilation aborted!
The issue was introduced at https://reviews.llvm.org/rL345250.
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57444/new/

https://reviews.llvm.org/D57444





More information about the llvm-commits mailing list