[PATCH] D57871: Fix some cases where icmp (bitcast ([su]itofp X)), Y is misfolded

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

OK, looks good, but might be a good idea for someone else to look.
While this bug was already released in 7.0, it is still a bug,
so you might want to file backport request for 8.0



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:4953
 
   // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
   Value *X;
----------------
lebedev.ri wrote:
> Adjust comment too?
> `// Zero-equality and sign-bit checks are preserved through sitofp + bitcast, if bitcast does not change the number of elements.`
Hmm, the comment i suggested reads wrong/alien, but i can't suggest a better one.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57871/new/

https://reviews.llvm.org/D57871