[PATCH] D57812: [ARM] Add OptMinSize Subtarget feature

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 03:41:48 PST 2019


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Please wait till tomorrow with committing, in case Eli has any additional comments.



================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:267
+  std::string Key = CPU + FS;
+  if (F.optForMinSize())
+    Key += "+minsize";
----------------
Might be worth calling out what is going on here in a comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57812/new/

https://reviews.llvm.org/D57812





More information about the llvm-commits mailing list