[PATCH] D57738: [llvm-objcopy] Add --redefine-syms

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D57738#1388520 <https://reviews.llvm.org/D57738#1388520>, @evgeny777 wrote:

> > Actually, on second thoughts, I think this should be an error. If a user specifies a line in the file that is a bad format, that's as bad as doing the same on the command-line, so should be treated with the same severity.
>
> So do you actually want to trigger error in both (cl and file) cases?


No - the two cases are different, due to the different formats. In the cl case, a missing '=' causes a bad format error. If an '=' is present, the (potentially empty) string after it is the new name. In the file case, the separator is a space character, so the error should occur if there are no spaces (after trimming). That way, if a user writes "foo=bar" in the file, they'll get an error.

> If so should there be a way to replace some symbol foo with an empty symbol?

Replacing symbol foo with an empty-name symbol probably is one of those corner cases that we should only support on the command-line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57738/new/

https://reviews.llvm.org/D57738