[PATCH] D57877: [llvm-objcopy] Add few file processing directives

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-symbol.test:9
+# RUN: echo "b.*" > %t-list.txt
+# RUN: echo " # empty symbol name with comment" >> %t-list.txt
+# RUN: llvm-objcopy --regex --strip-symbols %t-list.txt %t %t5
----------------
jhenderson wrote:
> Why is this tested under strip-symbol and not the other cases?
> 
> Related aside: this is a good example of where unit testing should be present because really we're testing the symbol reading from file function not the switch behaviour.
> Why is this tested under strip-symbol and not the other cases?

What's the point of doing this everywhere? We're using the same file parser for all cases


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57877/new/

https://reviews.llvm.org/D57877