[PATCH] D57738: [llvm-objcopy] Add --redefine-syms

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 7 01:19:13 PST 2019


jhenderson added a comment.

In D57738#1387137 <https://reviews.llvm.org/D57738#1387137>, @jhenderson wrote:

> I like the warning, especially if it has the line number in of the offending line(s).


Actually, on second thoughts, I think this should be an error. If a user specifies a line in the file that is a bad format, that's as bad as doing the same on the command-line, so should be treated with the same severity.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57738/new/

https://reviews.llvm.org/D57738





More information about the llvm-commits mailing list