igorb added a comment. The change looks ok. Could you please add mir test for InstructionSelector pass, similar to select-memop-scalar.mir. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57803/new/ https://reviews.llvm.org/D57803