[PATCH] D57449: GlobalISel: Add alignment to LegalityQuery MMOs

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 23:29:46 PST 2019


aemerson added a comment.

@dsanders does this look ok to you?



================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:180
+
+  bool isCompatible(const TypePairAndMemDesc &Other) const {
+    return Type0 == Other.Type0 && Type1 == Other.Type1 &&
----------------
This isCompatible relation isn't commutative, so it would be good to make it clear here what it actually means for A.isCompatible(B) to be true.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57449/new/

https://reviews.llvm.org/D57449





More information about the llvm-commits mailing list