[PATCH] D57478: GlobalISel: Implement fewerElementsVector for shifts

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

Thanks, it looks better now.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1850
+                      LeftoverRegs))
+      llvm_unreachable("should have been able to extractParts");
+
----------------
arsenm wrote:
> arsenm wrote:
> > aemerson wrote:
> > > We can return 0 here to fall back instead of dying.
> > Is it OK I fa failed legalization created dead instructions?
> This should also consistently fail along with getNarrowTypeBreakDown, previously checked
If legalization fails then the resulting MF is usually invalid and deleted anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57478/new/

https://reviews.llvm.org/D57478