[PATCH] D57849: llvm-dwarfdump: Stop counting out-of-line subprogram in the "inlined functions" statistic.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/tools/llvm-dwarfdump/X86/statistics.ll:21
 ; +1 extra inline i.
-; CHECK: "source variables":8
+; CHECK: "source variables":5
 ; -1 square::i
----------------
According to the comment on line 20 "source variables" is expected to be "unique source variables"+"number of extra inlined instances". If we want to change this we should update the comment as well.

I'd expect this program to have GlobalConst, Global, constant, s, square::i, cube:i, cube::squared = 7 unique variables, and source variables should be one more than that because it also counts the inlined square::i inside of cube.

This obviously isn't documented very well :-(, but based on that do you think this looks more like a bug in the documentation or do you think the algorithm is wrong?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57849/new/

https://reviews.llvm.org/D57849