[PATCH] D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 6 13:22:41 PST 2019
ruiu added inline comments.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:238
+ if (Thin)
+ Out << computeRelativePath(ArcName, M.MemberName);
+ else
----------------
So, M.MemberName is relative to ArcName if it is thin, and it is used as-is if not thin. It doesn't look like we really have to distinguish two here. Could you call `computeRelativePath` early in llvm-ar and set its result to MemberName? Then I think you can remove special handling of thin archive here.
================
Comment at: llvm/test/tools/llvm-ar/flatten-thin-archive-directories.test:15
+
+# FIXME: ar t mistakenly prepends / here, this should be "foo/a.txt".
+CHECK: /foo/a.txt
----------------
Are you going to fix this bug as well?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57842/new/
https://reviews.llvm.org/D57842
More information about the llvm-commits
mailing list