[PATCH] D57535: [CMake] Use LLVM_ENABLE_PROJECTS as the "single source" of truth when used.

Wed Feb 6 13:08:30 PST 2019

smeenai added a comment.

In D57535#1387661 <https://reviews.llvm.org/D57535#1387661>, @lei wrote:

> @delcypher  I am having a problem with my internal build after this change have gone in.  Can you please help to determine what went wrong?  Previously I was able to do the following:
>
>   $ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On '-DLLVM_ENABLE_PROJECTS=clang;llvm;compiler-rt;clang-tools-extra;openmp;lld' -DCMAKE_C_COMPILER=/home/llvm/gcc/7.3.0/bin/gcc -DCMAKE_CXX_COMPILER=/home/llvm/gcc/7.3.0/bin/g++ -DLLVM_BINUTILS_INCDIR=/usr/include $LLVM_SRC
>   $ ninja -j 20
>   $ ninja check-libomptarget check-openmp
>
>
> After your patch, I get the following warning with the the cmake cmd:
>
>   CMake Warning:
>     Manually-specified variables were not used by the project:
>       LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES
>       LIBOMPTARGET_NVPTX_ENABLE_BCLIB
>       OPENMP_ENABLE_LIBOMPTARGET
>
>
> and:
>
>   $ ninja check-libomptarget check-openmp
>   ninja: error: unknown target 'check-libomptarget
>

openmp isn't in LLVM_ALL_PROJECTS, so it'll get ignored. I just pushed r353343 to fix that, and I'll put up a patch addressing the larger problem.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57535/new/

https://reviews.llvm.org/D57535