[PATCH] D57533: lit: support long paths on Windows

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 12:42:45 PST 2019


rnk added a comment.

In D57533#1387168 <https://reviews.llvm.org/D57533#1387168>, @compnerd wrote:

> I think that of the 251 characters, we should reserve at least `\Users\????????\swift-source\build\Ninja-RelWithDebInfoAssert\swift-windows-x86_64` as a prefix because that is going to be pretty common ... which doesn't leave you with much space to play with.


I learned the pattern of using something like `C:\b\${botname}` as the root of the buildbot directory from Chrome infra, probably for this reason. =D

While I agree with @ruiu that this problem will probably eventually solve itself (as we have seen in other areas like Windows 10 console improvements), I think it's worth adding this in as a stopgap measure. I just think the lead time on a proper fix in Windows is going to be pretty long.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list