[PATCH] D57800: [WebAssembly] LTO: Set POSIX thread model when linking with -shared-memoey
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 6 11:32:31 PST 2019
sbc100 added a comment.
Still working on a test case..
In D57800#1387400 <https://reviews.llvm.org/D57800#1387400>, @dschuff wrote:
> I think we should change the logic in the backend to use the atomics target feature rather than the thread model to determine whether to run the LowerAtomics pass. Then this won't be necessary since the functions will have the appropriate attribute.
I agree in the long term that make sense, but for now I'd like to match clang. Currently the clang wasm toolchain has WebAssembly::getThreadModel() which specific "single" by default. Once we remove that then we can also remove this patch and possible completely from the ThreadModel LTO option.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57800/new/
https://reviews.llvm.org/D57800
More information about the llvm-commits
mailing list