[PATCH] D57807: build: Remove the cmake check for malloc.h.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 11:19:07 PST 2019


pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/Support/Unix/Process.inc:36
-// DragonFlyBSD, and OpenBSD have deprecated <malloc.h> for
-// <stdlib.h> instead. Unix.h includes this for us already.
-#if defined(HAVE_MALLOC_H) && !defined(__DragonFly__) && \
----------------
thakis wrote:
> This change kind of assumes that HAVE_MALLINFO is false on dragonfly and openbsd. But I suppose it's consistent with `check_symbol_exists(mallinfo malloc.h HAVE_MALLINFO)` in config-ix.cmake.
Yes and neither of those platforms have a mallinfo, or ever had it as far as I can tell, so this change should be fine on those platforms.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57807/new/

https://reviews.llvm.org/D57807





More information about the llvm-commits mailing list